[Asterisk-code-review] app.c: Remove deletion of pool topic on mwi state delete (...asterisk[13])

Joshua C. Colp asteriskteam at digium.com
Mon Mar 11 06:25:00 CDT 2019


Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11114 )

Change subject: app.c:  Remove deletion of pool topic on mwi state delete
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11114/1/res/res_pjsip_mwi.c 
File res/res_pjsip_mwi.c:

https://gerrit.asterisk.org/#/c/11114/1/res/res_pjsip_mwi.c@266 
PS1, Line 266: 	/* The subscribe steals the topic ref */
I don't understand this comment in relation to the below unref. Which subscribe, who is stealing.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11114
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27
Gerrit-Change-Number: 11114
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 11:25:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190311/61cd2648/attachment.html>


More information about the asterisk-code-review mailing list