[Asterisk-code-review] partial-inlining: disable partial-inlining if gcc>=8.2 (...asterisk[16])

[Christian Savinovich]

Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11106

to look at the new patch set (#3).

Change subject: partial-inlining: disable partial-inlining if gcc>=8.2
......................................................................

partial-inlining: disable partial-inlining if gcc>=8.2

Apply flag -fno-partial-inlining on default optimization if and only if
gcc version >= 8.2 (Will occur if latest Fedora or Ubuntu). This is done to
avoid a bug that causes arithmetic calculations to fail if the
following conditions are met:
1. TEST_FRAMEWORK on
2. DONT_OPTIMIZE off
3. Fedora and Ubuntu
4. GCC 8.2.1
5. There must exist a certain combination of multithreading.
6. Optimization level -O2 and -O3
7. Flag -fpartial-inline activated (default if optimization level>=2)
The following link points to a similar gcc bug reported in 2015. This leads me
to believe the bug has regressed. Note I am not able to replicate this bug
in an environment other than Asterisk + Test Framework + Test_cel because the
multithreading combination that causes it seems to be unique. Therefore I
am temporarily abandoning any thoughts of reporting the new occurrence of this
bug to gcc.gnu.org.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65307

Change-Id: Ibd1afe60e0a38b88e85fdcd9b051004601c2f102
---
M Makefile.rules
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/06/11106/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11106
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ibd1afe60e0a38b88e85fdcd9b051004601c2f102
Gerrit-Change-Number: 11106
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190308/7ca0f829/attachment.html>