[Asterisk-code-review] jansson: Add bogus call at startup to verify required version. (...asterisk[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11112 )

Change subject: jansson: Add bogus call at startup to verify required version.
......................................................................


Patch Set 2:

> @Corey - In case you miss it from IRC, it would be better if you
 > tried to just the new format string in a known-working way, catch
 > the error, and then print a message about version mismatch. And
 > then (maybe?) prevented Asterisk from booting?

Definitely prevent startup.  In addition to the new formats that we can detect at runtime, jansson-2.11 introduced thread safe reference counting and json_dump.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11112
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I101aebafe0f9407650206f7c552dad3d69377b5a
Gerrit-Change-Number: 11112
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 08 Mar 2019 18:44:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190308/1434761e/attachment.html>