[Asterisk-code-review] Replace calls to strtok() with strtok_r() (...asterisk[13])
Kevin Harwell
asteriskteam at digium.com
Thu Mar 7 16:27:59 CST 2019
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11099 )
Change subject: Replace calls to strtok() with strtok_r()
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
-1 just so the questions gets seen
https://gerrit.asterisk.org/#/c/11099/2/include/asterisk.h
File include/asterisk.h:
https://gerrit.asterisk.org/#/c/11099/2/include/asterisk.h@54
PS2, Line 54: #define strtok __PLEASE_USE_strtok_r_INSTEAD_OF_strtok__
Do we want to make this master only? Couldn't this potentially keep some external libs from compiling? Do we care in this instance?
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11099
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Icce265153e1e65adafa8849334438ab6d190e541
Gerrit-Change-Number: 11099
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 22:27:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190307/d58431b7/attachment.html>
More information about the asterisk-code-review
mailing list