[Asterisk-code-review] res_stasis: Add ability to switch applications. (...asterisk[13])

Sean Bright asteriskteam at digium.com
Wed Mar 6 14:20:08 CST 2019


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10937 )

Change subject: res_stasis: Add ability to switch applications.
......................................................................


Patch Set 14: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10937/14/res/stasis/control.c 
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/10937/14/res/stasis/control.c@500 
PS14, Line 500: 		token = strtok(move_data->app_args, ",");
strtok() is not thread-safe, so either this is unsafe or I don't understand something. Both are equally possible.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10937
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I43d12b10045a98a8d42541889b85695be26f288a
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 14
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 20:20:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190306/6c2ea2d7/attachment.html>


More information about the asterisk-code-review mailing list