[Asterisk-code-review] res/res_rtp_asterisk.c: Fixing possible divide by zero (...asterisk[master])

sungtae kim asteriskteam at digium.com
Tue Mar 5 09:52:51 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11085 )

Change subject: res/res_rtp_asterisk.c: Fixing possible divide by zero
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Is there a case where you've already seen this or can demonstrate? I'm not a huge fan of changing legacy things even if minor.

Nope, couldn't see it yet. :P
I just found this while I'm digging the stats things and imagined it, this might be causing the this problem.

For me, it's not an easy to reproduce it.

I just imagined it may causing the service denied attack by sending lots of RTCP packets.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11085
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If7e0629abaceddd2166eb012456c53033ea26249
Gerrit-Change-Number: 11085
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 15:52:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190305/f7f159e2/attachment.html>


More information about the asterisk-code-review mailing list