[Asterisk-code-review] chan_pjsip: add a flag to ignore 183 responses if no SDP present (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11086 )

Change subject: chan_pjsip: add a flag to ignore 183 responses if no SDP present
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11086/3/configs/samples/pjsip.conf.sample 
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/11086/3/configs/samples/pjsip.conf.sample@829 
PS3, Line 829: ;ignore_183_without_sdp =
             :                            ; Do not forward 183 when it doesn't contain SDP
             :                            ; Certian SS7 internetworking scenarios can result in a 183
             :                            ; to be generated for reasons other than early media.  Forwarding
             :                            ; this 183 can cause loss of ringback tone.  This flag emulates
             :                            ; the behavior of chan_sip and prevents these 183 responses from
             : 			   ; being forwarded.
             :                            ; (default: no)
Weird leading whitespace on line 835. Also, I know this file isn't very consistent, but try to wrap at 80 columns like the section above.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11086
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If81cfaa17c11b6ac703e3d71696f259d86c6be4a
Gerrit-Change-Number: 11086
Gerrit-PatchSet: 3
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 15:27:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190305/268ecc7f/attachment-0001.html>