[Asterisk-code-review] res_stasis: Add ability to switch applications. (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10937 )

Change subject: res_stasis: Add ability to switch applications.
......................................................................


Patch Set 11: Code-Review-1

(3 comments)

Minor thing.

https://gerrit.asterisk.org/#/c/10937/11/res/stasis/control.c 
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/10937/11/res/stasis/control.c@510 
PS11, Line 510: 	AST_VECTOR_APPEND(&control->next_app_args, ast_strdup(arg));
              : 		ast_free(arg);
You should steal arg here, instead of ast_strduping it. As it is the ast_strdup can fail, and may leave things in an incomplete state for arguments.


https://gerrit.asterisk.org/#/c/10937/11/res/stasis/control.c@528 
PS11, Line 528: 	strcpy(move_data->app_name, app_name);
Mark this as being safe


https://gerrit.asterisk.org/#/c/10937/11/res/stasis/control.c@542 
PS11, Line 542: 			AST_VECTOR_APPEND(&move_data->args, ast_strdup(token));
This can fail, so deciding what to do in that case is a good idea



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10937
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I43d12b10045a98a8d42541889b85695be26f288a
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 11
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 13:28:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190305/e5fb4338/attachment.html>