[Asterisk-code-review] chan_pjsip: add a flag to ignore 183 responses if no SDP present (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11086 )

Change subject: chan_pjsip: add a flag to ignore 183 responses if no SDP present
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

I think this should also be placed into CHANGES and mentioned in the pjsip.conf.sample file.

https://gerrit.asterisk.org/#/c/11086/1/res/res_pjsip/pjsip_configuration.c 
File res/res_pjsip/pjsip_configuration.c:

https://gerrit.asterisk.org/#/c/11086/1/res/res_pjsip/pjsip_configuration.c@1904 
PS1, Line 1904: 	ast_sorcery_object_field_register(sip_sorcery, "endpoint", "ignore_183_without_sdp", "no", OPT_BOOL_T, 1, FLDSET(struct ast_sip_endpoint, ignore_183_without_sdp));
This option hasn't been documented in the XML in res_pjsip.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11086
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If81cfaa17c11b6ac703e3d71696f259d86c6be4a
Gerrit-Change-Number: 11086
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 05 Mar 2019 12:58:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190305/43667672/attachment.html>