[Asterisk-code-review] chan_sip, chan_iax2, chan_pjsip: Allow updating variable values. (...asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Mar 5 06:36:03 CST 2019


Joshua Colp has uploaded a new patch set (#5) to the change originally created by Guido Falsi. ( https://gerrit.asterisk.org/c/asterisk/+/10930 )

Change subject: chan_sip, chan_iax2, chan_pjsip: Allow updating variable values.
......................................................................

chan_sip, chan_iax2, chan_pjsip: Allow updating variable values.

When modifying an already defined setvar variable in chan_sip,
chan_iax2, and chan_pjsip drivers they add a new variable with
the same name instead of replacing the already existing variable.
This causes the old value to be used instead of the new one.

This change makes the code replace the old value with the new
one. The chan_dahdi driver already conforms to this, more logical,
behavior.

Support for setting channel variables on peers in chan_iax2
has also been added using the "setvar" option.

ASTERISK-23756
patches:
  setvar-multiplie.patch submitted by Michael Goryainov

Change-Id: Ie1897a96c82b8945e752733612ee963686f32839
---
M CHANGES
M channels/chan_iax2.c
M channels/chan_sip.c
M configs/samples/iax.conf.sample
M res/res_pjsip/pjsip_configuration.c
5 files changed, 84 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/30/10930/5
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10930
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie1897a96c82b8945e752733612ee963686f32839
Gerrit-Change-Number: 10930
Gerrit-PatchSet: 5
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190305/a70c9120/attachment.html>


More information about the asterisk-code-review mailing list