[Asterisk-code-review] app_queue: Handle empty 'interface' in queue member config (...asterisk[13])

Sean Bright asteriskteam at digium.com
Mon Mar 4 16:07:25 CST 2019


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11094

to look at the new patch set (#2).

Change subject: app_queue: Handle empty 'interface' in queue member config
......................................................................

app_queue: Handle empty 'interface' in queue member config

While the 'interface' column is a NOT NULL, the empty string is still
allowed. res_config_odbc treats the empty string as a NULL and we crash
when trying to dereference.

Also cleaned up an adjacent error message for consistency.

ASTERISK-28168 #close

Change-Id: I55e012b540fbcda99bb40bede3099b7ae5db8202
---
M apps/app_queue.c
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/94/11094/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11094
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I55e012b540fbcda99bb40bede3099b7ae5db8202
Gerrit-Change-Number: 11094
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190304/ddc7a990/attachment.html>


More information about the asterisk-code-review mailing list