[Asterisk-code-review] sip_to_pjsip: Make multiline comment parsing consistent with Asterisk (...asterisk[13])

Corey Farrell asteriskteam at digium.com
Mon Mar 4 13:04:57 CST 2019


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11091 )

Change subject: sip_to_pjsip: Make multiline comment parsing consistent with Asterisk
......................................................................


Patch Set 1:

> Not a Python guy, so I will cherrypick this once the Python
 > powers-that-be let me know if this is idiomatic Python or not.

I'm also not able to say if this is the correct way to do this or not, I can only say that I've tested and it seems to fix the bug.

BTW please link the JIRA ticket in the commit message.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11091
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I32dc38e0fac01d3c0805d27d35d2365a7c37ca72
Gerrit-Change-Number: 11091
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 19:04:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190304/24a20fe6/attachment.html>


More information about the asterisk-code-review mailing list