[Asterisk-code-review] res_stasis: Add ability to switch applications. (...asterisk[13])

Benjamin Keith Ford asteriskteam at digium.com
Mon Mar 4 08:16:42 CST 2019


Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10937 )

Change subject: res_stasis: Add ability to switch applications.
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.asterisk.org/#/c/10937/10/res/stasis/control.c 
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/10937/10/res/stasis/control.c@504 
PS10, Line 504: 	AST_VECTOR_FREE(&move_data->args);
> Once you add your custom destructor I _dont't_ think you'll need to do this.
Why does it not need to freed here? I know the contents will all be freed, but does it still have memory allocated for the pointer to the char pointers it originally contained, and would therefore still need to be freed? Maybe I'm missing something here



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10937
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I43d12b10045a98a8d42541889b85695be26f288a
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 10
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 04 Mar 2019 14:16:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190304/0a1e3a89/attachment.html>


More information about the asterisk-code-review mailing list