[Asterisk-code-review] res/res_rtp_asterisk.c: Fixing possible divide by zero (...asterisk[master])

sungtae kim asteriskteam at digium.com
Sun Mar 3 09:22:21 CST 2019


sungtae kim has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/11085


Change subject: res/res_rtp_asterisk.c: Fixing possible divide by zero
......................................................................

res/res_rtp_asterisk.c: Fixing possible divide by zero

Currently, when the Asterisk calculates rtp statistics, it uses
sample_count as a unsigned integer parameter. This would be fine
for most of cases, but in case of large enough number of sample_count,
this might be causing the divide by zero error.

ASTERISK-28321

Change-Id: If7e0629abaceddd2166eb012456c53033ea26249
---
M res/res_rtp_asterisk.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/85/11085/1

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 84b2088..e726cc0 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -3078,7 +3078,7 @@
 	return normdev / sample_count;
 }
 
-static double stddev_compute(double stddev, double sample, double normdev, double normdev_curent, unsigned int sample_count)
+static double stddev_compute(double stddev, double sample, double normdev, double normdev_curent, unsigned long sample_count)
 {
 /*
 		for the formula check http://www.cs.umd.edu/~austinjp/constSD.pdf

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11085
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If7e0629abaceddd2166eb012456c53033ea26249
Gerrit-Change-Number: 11085
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190303/b6216695/attachment.html>


More information about the asterisk-code-review mailing list