[Asterisk-code-review] Added ARI resource /ari/channels/{channelId}/stats (...asterisk[master])

sungtae kim asteriskteam at digium.com
Sat Mar 2 23:08:46 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11083 )

Change subject: Added ARI resource /ari/channels/{channelId}/stats
......................................................................


Patch Set 3:

Hi, when I doing 'make ari-stubs', it changing the code like the below. So I had to change the below line in manually. Did I something wrong? May I get some advise?

diff --git a/res/res_ari_channels.c b/res/res_ari_channels.c
index 571e38ead0..082fab25a9 100644
--- a/res/res_ari_channels.c
+++ b/res/res_ari_channels.c
@@ -2700,8 +2700,8 @@ static void ast_ari_channels_stats_cb(
                break;
        default:
                if (200 <= code && code <= 299) {
-                       is_valid = ast_ari_validate_list(response->message,
-                                       ast_ari_validate_channelstat_fn());
+                       is_valid = ast_ari_validate_list[channelstat](
+                               response->message);
                } else {
                        ast_log(LOG_ERROR, "Invalid error response %d for /channels/{channelId}/stats\n", code);
                        is_valid = 0;


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11083
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4343eec070438cec13f2a4f22e7fd9e574381376
Gerrit-Change-Number: 11083
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Sun, 03 Mar 2019 05:08:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190302/bb8c5457/attachment.html>


More information about the asterisk-code-review mailing list