[Asterisk-code-review] chan_sip, chan_iax2, chan_dahdi: Allow updating variable value. (...asterisk[master])

[Guido Falsi]

Guido Falsi has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/10930 )

Change subject: chan_sip, chan_iax2, chan_dahdi: Allow updating variable value.
......................................................................


Patch Set 12:

(1 comment)

> Patch Set 12:
> 
> (1 comment)

https://gerrit.asterisk.org/#/c/10930/12/channels/chan_iax2.c 
File channels/chan_iax2.c:

https://gerrit.asterisk.org/#/c/10930/12/channels/chan_iax2.c@10733 
PS12, Line 10733: 				peer = find_peer(iaxs[fr->callno]->peer, 1);
> oh and someone correct me if I am wrong, but I believe string field are initialized to NULL (prior t […]
Sorry for the delay.

That's also reported in a comment in register_verify.

If I get it correctly it means my call should be safe from crashes. I'm still not completely sure if the peer field is filled in at this point. I think it should but I'm not sure of the code path.

I'm going to setup a small testing environment and try some calls on a iax2 trunk and see what happens. If everything looks fine I'll push for this to be accepted.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/10930
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie1897a96c82b8945e752733612ee963686f32839
Gerrit-Change-Number: 10930
Gerrit-PatchSet: 12
Gerrit-Owner: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Sat, 29 Jun 2019 10:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Guido Falsi <madpilot at freebsd.org>
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190629/9e0f5787/attachment.html>