[Asterisk-code-review] app_voicemail.c: Build all three variants for app_voicemail at the sa... (...asterisk[16])

George Joseph asteriskteam at digium.com
Thu Jun 27 14:18:45 CDT 2019


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11493 )

Change subject: app_voicemail.c: Build all three variants for app_voicemail at the same time
......................................................................


Patch Set 3: Code-Review-2

(2 comments)

we're going to do this in master only

https://gerrit.asterisk.org/#/c/11493/3/apps/Makefile 
File apps/Makefile:

https://gerrit.asterisk.org/#/c/11493/3/apps/Makefile@26 
PS3, Line 26:  
extra space crept in.


https://gerrit.asterisk.org/#/c/11493/3/doc/UPGRADE-staging/Build_all_3_app_voicemail_variants_at_the_same_time.txt 
File doc/UPGRADE-staging/Build_all_3_app_voicemail_variants_at_the_same_time.txt:

https://gerrit.asterisk.org/#/c/11493/3/doc/UPGRADE-staging/Build_all_3_app_voicemail_variants_at_the_same_time.txt@5 
PS3, Line 5: 30
I think you meant 3)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11493
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Iba3cd8ffb4b7e8b1c64a11dd383e1eafcd3ed0e7
Gerrit-Change-Number: 11493
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 19:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190627/58c17a43/attachment.html>


More information about the asterisk-code-review mailing list