[Asterisk-code-review] app_amd: issue with silence suppression fixed (...asterisk[master])

Kevin Harwell asteriskteam at digium.com
Thu Jun 27 11:33:23 CDT 2019


Kevin Harwell has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11488 )

Change subject: app_amd: issue with silence suppression fixed
......................................................................

app_amd: issue with silence suppression fixed

Now AMD algorithm will not ignore AST_FRAME_NULL, As I think using manual
wait time instead of `framelength` is enough to fix timeout / TOOLONG issue.

ASTERISK-28419 #close

Change-Id: I16ea2d6295bc99b975e8c092e5f9fbd9214debdb
---
M apps/app_amd.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved; Approved for Submit



diff --git a/apps/app_amd.c b/apps/app_amd.c
index 5285287..1a0af3f 100644
--- a/apps/app_amd.c
+++ b/apps/app_amd.c
@@ -293,7 +293,7 @@
 			break;
 		}
 
-		if (f->frametype == AST_FRAME_VOICE || f->frametype == AST_FRAME_CNG) {
+		if (f->frametype == AST_FRAME_VOICE || f->frametype == AST_FRAME_NULL || f->frametype == AST_FRAME_CNG) {
 			/* Figure out how long the frame is in milliseconds */
 			if (f->frametype == AST_FRAME_VOICE) {
 				framelength = (ast_codec_samples_count(f) / DEFAULT_SAMPLES_PER_MS);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11488
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I16ea2d6295bc99b975e8c092e5f9fbd9214debdb
Gerrit-Change-Number: 11488
Gerrit-PatchSet: 1
Gerrit-Owner: Nasir Iqbal <nasir at ictinnovations.com>
Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Nasir Iqbal <nasir at ictinnovations.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190627/11e94fc6/attachment-0001.html>


More information about the asterisk-code-review mailing list