[Asterisk-code-review] mwi: Update the MWI core to use stasis_state API (...asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11463 )

Change subject: mwi: Update the MWI core to use stasis_state API
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/11463/2/include/asterisk/mwi.h 
File include/asterisk/mwi.h:

https://gerrit.asterisk.org/#/c/11463/2/include/asterisk/mwi.h@250 
PS2, Line 250: /*! \brief MWI state event interface */
> Same here like the other review - it feels as though this belongs in its own header file.
Can do if ya like. It'd still need to be public. Something like mwi_observer.h?


https://gerrit.asterisk.org/#/c/11463/2/main/mwi.c 
File main/mwi.c:

https://gerrit.asterisk.org/#/c/11463/2/main/mwi.c@323 
PS2, Line 323: 	mwi_state =	mwi_create_state(id, NULL, 0, 0, 0);
> Why the weird indentation? O. […]
Ha took me a second to even see what you meant.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11463
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I93f935f9090cd5ddff6d4bc80ff90703c05cf776
Gerrit-Change-Number: 11463
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 24 Jun 2019 22:47:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190624/05757503/attachment.html>