[Asterisk-code-review] res_rtp_asterisk: Add support for DTLS packet fragmentation. (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11467 )

Change subject: res_rtp_asterisk: Add support for DTLS packet fragmentation.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/11467/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/11467/1/res/res_rtp_asterisk.c@199 
PS1, Line 199: #if defined(HAVE_OPENSSL) && (OPENSSL_VERSION_NUMBER >= 0x10001000L) && !defined(OPENSSL_NO_SRTP)
This is repeated _a lot_. Can we just define a HAS_THE_MTU_HOTNESS and use that throughout? Not required, just something I noticed.


https://gerrit.asterisk.org/#/c/11467/1/res/res_rtp_asterisk.c@6857 
PS1, Line 6857: dtls_mtu <= 256
Changelog says the minimum is 256, this says the minimum is 257.


https://gerrit.asterisk.org/#/c/11467/1/res/res_rtp_asterisk.c@6861 
PS1, Line 6861:                 }
              :         }
Weird leading spaces



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11467
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: If2d5032019a28ffd48f43e9e93ed71dbdbf39c06
Gerrit-Change-Number: 11467
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 13 Jun 2019 13:45:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190613/e49ff5c2/attachment.html>