[Asterisk-code-review] cdr_pgsql: fix error in connection string (...asterisk[16])

Christian Savinovich asteriskteam at digium.com
Tue Jun 4 13:37:41 CDT 2019


Hello Richard Mudgett, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11441

to look at the new patch set (#2).

Change subject: cdr_pgsql: fix error in connection string
......................................................................

cdr_pgsql: fix error in connection string

Fixes an error occurring in function pgsql_reconnect() caused when value of
hostname is blank. Which in turn will cause the connection string to look
like this: "host= port=xx", which creates a sintax error. This fix now checks
if the corresponding values for host, port, dbname, and user are blank. Note
that since this is a reconnect function the database library will replace any
missing value pairs with default ones.

ASTERISK-28435

Change-Id: I0a921f99bbd265768be08cd492f04b30855b8423
---
M cdr/cdr_pgsql.c
1 file changed, 19 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/41/11441/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11441
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I0a921f99bbd265768be08cd492f04b30855b8423
Gerrit-Change-Number: 11441
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190604/006af157/attachment.html>


More information about the asterisk-code-review mailing list