[Asterisk-code-review] core/tcptls: fix double socket close() on failed connection to offlin... (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11419 )

Change subject: core/tcptls: fix double socket close() on failed connection to offline TCP peer
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/11419/1/main/tcptls.c 
File main/tcptls.c:

https://gerrit.asterisk.org/#/c/11419/1/main/tcptls.c@552 
PS1, Line 552: 	if (!tcptls_session->stream) {
Should it be documented in the header file about accept_fd and its usage?


https://gerrit.asterisk.org/#/c/11419/1/main/tcptls.c@595 
PS1, Line 595: if (desc->accept_fd != -1) {
             : 		close(desc->accept_fd);
             : 	}
If accept_fd is no longer used, should this still exist?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11419
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idf0f7f5b4b304c37e89ef8352cbf976bebf96342
Gerrit-Change-Number: 11419
Gerrit-PatchSet: 1
Gerrit-Owner: under <under at list.ru>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 12:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190604/dfc52ccb/attachment-0001.html>