[Asterisk-code-review] CI: Don't enable non-core modules in Certified branches (...asterisk[certified/16.3])

George Joseph asteriskteam at digium.com
Fri Jul 26 09:48:13 CDT 2019


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/11625 )

Change subject: CI:  Don't enable non-core modules in Certified branches
......................................................................

CI:  Don't enable non-core modules in Certified branches

We don't support non-core modules for Certified releases but we
were enabling them for CI builds which was causing lots of test
failures.  Now we don't.

Change-Id: I0b3254c08a2479f3d39151690350cce5ce5ad766
---
M tests/CI/buildAsterisk.sh
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/tests/CI/buildAsterisk.sh b/tests/CI/buildAsterisk.sh
index 6877eaf..adbc3b0 100755
--- a/tests/CI/buildAsterisk.sh
+++ b/tests/CI/buildAsterisk.sh
@@ -116,12 +116,20 @@
 		runner menuselect/menuselect --enable REF_DEBUG menuselect.makeopts
 	fi
 
-	cat_enables="MENUSELECT_BRIDGES MENUSELECT_CEL MENUSELECT_CDR"
-	cat_enables+=" MENUSELECT_CHANNELS MENUSELECT_CODECS MENUSELECT_FORMATS MENUSELECT_FUNCS"
-	cat_enables+=" MENUSELECT_PBX MENUSELECT_RES MENUSELECT_UTILS MENUSELECT_TESTS"
+	cat_enables="MENUSELECT_TESTS"
+	mod_disables=""
+
+	if [[ ! "${BRANCH_NAME}" =~ ^certified ]] ; then
+		cat_enables+=" MENUSELECT_BRIDGES MENUSELECT_CEL MENUSELECT_CDR"
+		cat_enables+=" MENUSELECT_CHANNELS MENUSELECT_CODECS MENUSELECT_FORMATS MENUSELECT_FUNCS"
+		cat_enables+=" MENUSELECT_PBX MENUSELECT_RES MENUSELECT_UTILS"
+	else
+		mod_disables+="test_utils"
+	fi
+
 	runner menuselect/menuselect `gen_cats enable $cat_enables` menuselect.makeopts
 
-	mod_disables="res_digium_phone chan_vpb"
+	mod_disables+=" res_digium_phone chan_vpb"
 	if [ $TESTED_ONLY -eq 1 ] ; then
 		# These modules are not tested at all.  They are loaded but nothing is ever done
 		# with them, no testsuite tests depend on them.

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11625
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.3
Gerrit-Change-Id: I0b3254c08a2479f3d39151690350cce5ce5ad766
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190726/e91f610c/attachment.html>


More information about the asterisk-code-review mailing list