[Asterisk-code-review] CI: Don't enable non-core modules in Certified branches (...asterisk[certified/16.3])

Kevin Harwell asteriskteam at digium.com
Thu Jul 25 10:51:18 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11625 )

Change subject: CI:  Don't enable non-core modules in Certified branches
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/11625/3/tests/CI/buildAsterisk.sh 
File tests/CI/buildAsterisk.sh:

https://gerrit.asterisk.org/#/c/11625/3/tests/CI/buildAsterisk.sh@126 
PS3, Line 126: 	else
             : 		mod_disables+="test_utils"
             : 	fi
I noticed this 'else' (disabling of test_utils) is just in the patches for the certified branches. To keep things more inline should this also be in the other branches?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11625
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.3
Gerrit-Change-Id: I0b3254c08a2479f3d39151690350cce5ce5ad766
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 25 Jul 2019 15:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190725/3ac0af56/attachment.html>


More information about the asterisk-code-review mailing list