[Asterisk-code-review] openr2(1/6): bugfix in configuration saving (...asterisk[16])

Oron Peled asteriskteam at digium.com
Mon Jul 22 12:54:40 CDT 2019


Hello Tzafrir Cohen, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11603

to look at the new patch set (#2).

Change subject: openr2(1/6): bugfix in configuration saving
......................................................................

openr2(1/6): bugfix in configuration saving

Details:
  - The memcpy() call copied part of "dahdi_conf" and not "dahdi_conf.mfcr2"
  - As a result, the memcmp() in dahdi_r2_get_link() always fails
  - This cause dahdi_r2_get_link() to create new link for every channel
    (instead of a new link for every ~30 channels)
  - With the fix, far less links are generated -- so we use far less threads

Change-Id: I7259dd6272f5e46e8a6c7f5bf3e8c2ec01b8c132
Signed-off-by: Oron Peled <oron.peled at xorcom.com>
---
M channels/chan_dahdi.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/03/11603/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11603
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7259dd6272f5e46e8a6c7f5bf3e8c2ec01b8c132
Gerrit-Change-Number: 11603
Gerrit-PatchSet: 2
Gerrit-Owner: Oron Peled <oron.peled at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190722/ebe459eb/attachment-0001.html>


More information about the asterisk-code-review mailing list