[Asterisk-code-review] chan_pjsip: Transmit REFER waits for the REFER result setting TRANSF... (...asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11216 )

Change subject: chan_pjsip:  Transmit REFER waits for the REFER result setting TRANSFERSTATUS
......................................................................


Patch Set 7:

> Patch Set 7:
> 
> We have downloaded the testsuite here and run it with the changes and are not seeing the errors.  
> 
> We suspect we are not following the same process that the Friendly Automation does.  Is there a description of the process we need to run to replicate the 2 failures with the testsuite?

It seems to fail for me locally every time too with your patch. At least the endpoint/refer one does. I did not check the other one. I used the following to configure Asterisk:

./configure --enable-dev-mode --with-pjproject-bundled --with-jansson-bundled

And then have the following compiler flags set in menuselect (not sure if it would matter):

DONT_OPTIMIZE, BETTER_BACKTRACES, BUILD_NATIVE, OPTIONAL_API, DO_CRASH, TEST_FRAMEWORK

I then ran the test:

./runtests.py -t tests/channels/pjsip/transfers/asterisk/endpoint/refer/

I ran it twice and it failed both times with your patch installed. Without your patch it seems to pass fine.

If you'd like to see how Jenkins (Friendly automation) handles it you can checkout the full console log of the run:

https://jenkins2.asterisk.org/job/asterisk-gatetests/job/master/700/consoleFull

Search for "configure" and you should see the configure line it uses for Asterisk. Also search for menuselect and you should be able to see which menuselect flags get enabled/disabled.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11216
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6c27c757c66f71e8b75e3fe49da53ebe62395dc
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 7
Gerrit-Owner: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Dan Cropp <dan at amtelco.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Mon, 22 Jul 2019 17:06:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190722/43d60440/attachment.html>