[Asterisk-code-review] pjsip/registration/inbound/off-nominal/wrong_password: Add no passwor... (...testsuite[13])

Friendly Automation asteriskteam at digium.com
Mon Jul 22 07:57:01 CDT 2019


Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/testsuite/+/11585 )

Change subject: pjsip/registration/inbound/off-nominal/wrong_password: Add no password check
......................................................................

pjsip/registration/inbound/off-nominal/wrong_password: Add no password check

Added a second set of registration attempts that do not include the password
at all. This verifies that asterisk still responds correctly.

Change-Id: I580c3a9794288745b915a65602049e8b045e4650
---
M tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/test-config.yaml
1 file changed, 17 insertions(+), 4 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/test-config.yaml b/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/test-config.yaml
index 144ed0d..a9b8239 100644
--- a/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/test-config.yaml
+++ b/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/test-config.yaml
@@ -1,10 +1,10 @@
 testinfo:
-    summary:     'Attempt to register using a wrong password'
+    summary: 'Attempt to register using a wrong password and also no password'
     description: |
         'Using all combinations of IPv4/IPv6 and UDP/TCP, run SIPp scenarios
-         that attempt to register to Asterisk using a wrong password. This
-         ensures that Asterisk rejects the registration attempt with a 401
-         Unauthorized.'
+         that attempt to register to Asterisk using a wrong password, and also
+         no password. This ensures that Asterisk rejects the registration
+         attempt with a 401 Unauthorized.'
 
 test-modules:
     test-object:
@@ -28,6 +28,19 @@
 
                 # IPv6 & TCP - register attempt with wrong password
                 - { 'key-args': {'scenario': 'register-wrong-password.xml', 'target': '[::1]', '-i': '[::1]', '-p': '5061', '-t': 't1', '-s': 'alice', '-au': 'alice', '-ap': 'wrong'} }
+        -
+            scenarios:
+                # IPv4 & UDP - register attempt with no password
+                - { 'key-args': {'scenario': 'register-wrong-password.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice', '-au': 'alice'} }
+
+                # IPv4 & TCP - register attempt with no password
+                - { 'key-args': {'scenario': 'register-wrong-password.xml', '-i': '127.0.0.1', '-p': '5061', '-t': 't1', '-s': 'alice', '-au': 'alice'} }
+
+                # IPv6 & UDP - register attempt with no password
+                - { 'key-args': {'scenario': 'register-wrong-password.xml', 'target': '[::1]', '-i': '[::1]', '-p': '5061', '-s': 'alice', '-au': 'alice'} }
+
+                # IPv6 & TCP - register attempt with no password
+                - { 'key-args': {'scenario': 'register-wrong-password.xml', 'target': '[::1]', '-i': '[::1]', '-p': '5061', '-t': 't1', '-s': 'alice', '-au': 'alice'} }
 
 properties:
     dependencies:

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11585
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-Change-Id: I580c3a9794288745b915a65602049e8b045e4650
Gerrit-Change-Number: 11585
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190722/5ac29291/attachment-0001.html>


More information about the asterisk-code-review mailing list