[Asterisk-code-review] openr2(5/6): added cli command -- mfcr2 destroy link <index> (...asterisk[13])
Kevin Harwell
asteriskteam at digium.com
Fri Jul 19 15:24:35 CDT 2019
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11537 )
Change subject: openr2(5/6): added cli command -- mfcr2 destroy link <index>
......................................................................
Patch Set 2: Code-Review-1
(4 comments)
https://gerrit.asterisk.org/#/c/11537/2/channels/chan_dahdi.c
File channels/chan_dahdi.c:
https://gerrit.asterisk.org/#/c/11537/2/channels/chan_dahdi.c@5585
PS2, Line 5585: * \since 1.8
Remove this line as it's not true.
https://gerrit.asterisk.org/#/c/11537/2/channels/chan_dahdi.c@13977
PS2, Line 13977: if (!pvt)
: continue;
Use braces around the 'if'
https://gerrit.asterisk.org/#/c/11537/2/channels/chan_dahdi.c@13990
PS2, Line 13990: if (!pvt)
: continue;
Use braces around the 'if'
https://gerrit.asterisk.org/#/c/11537/2/channels/chan_dahdi.c@14033
PS2, Line 14033: if (!pvt)
: continue;
Use braces around the 'if'
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11537
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I452d6a853bcd8c6e194455b19e5e017713e9c0fe
Gerrit-Change-Number: 11537
Gerrit-PatchSet: 2
Gerrit-Owner: Oron Peled <oron.peled at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 20:24:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190719/28c8e41b/attachment.html>
More information about the asterisk-code-review
mailing list