[Asterisk-code-review] openr2(4/6): added new cli command -- mfcr2 show links (...asterisk[13])

Kevin Harwell asteriskteam at digium.com
Fri Jul 19 15:13:03 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11536 )

Change subject: openr2(4/6): added new cli command -- mfcr2 show links
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11536/2/channels/chan_dahdi.c 
File channels/chan_dahdi.c:

https://gerrit.asterisk.org/#/c/11536/2/channels/chan_dahdi.c@15148 
PS2, Line 15148: 			switch (mfcr2->r2master) {
               : 			case 0L: thread_status = "zero";
               : 			case AST_PTHREADT_NULL: thread_status = "none";
               : 			default: thread_status = "created";
               : 			}
breaks needs to be added between cases or thread_status will always equal "created"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11536
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I213822e1b7ef9c05bd89a2ba62df8e0856ce9f84
Gerrit-Change-Number: 11536
Gerrit-PatchSet: 2
Gerrit-Owner: Oron Peled <oron.peled at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 20:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190719/572ab3e2/attachment.html>


More information about the asterisk-code-review mailing list