[Asterisk-code-review] openr2(3/6): Convert r2links to standard Asterisk AST_LIST* (...asterisk[13])

Joshua Colp asteriskteam at digium.com
Fri Jul 19 06:57:49 CDT 2019


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11535 )

Change subject: openr2(3/6): Convert r2links to standard Asterisk AST_LIST*
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/11535/2/channels/chan_dahdi.c 
File channels/chan_dahdi.c:

https://gerrit.asterisk.org/#/c/11535/2/channels/chan_dahdi.c@769 
PS2, Line 769: struct r2link_entry {
Why did you wrap dahdi_mfcr2 with an r2link_entry instead of just storing it directly in the linked list?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11535
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ibcb2401515a58782a1488c0b9efbed201c3f3a17
Gerrit-Change-Number: 11535
Gerrit-PatchSet: 2
Gerrit-Owner: Oron Peled <oron.peled at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 11:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190719/3a58579f/attachment.html>


More information about the asterisk-code-review mailing list