[Asterisk-code-review] feat: AudioSocket channel and application (...asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel and application
......................................................................


Patch Set 4:

I saw something that I thought was problematic but apparently not.

There are some coding guideline issues. The ones that jump out:

* Using spaces for indentation as opposed to tabs
* Some spacing issues (i.e. if/for/while should have a space before the opening paren)
* Files should probably all use the 'standard' header comment (main/alertpipe.c is an example of the standard header with a non-digium copyright)

Coding guidelines are here: https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 4
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 15:31:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190718/acedba8d/attachment.html>