[Asterisk-code-review] openr2(2/6): Stop polling channels when DAHDI returns -ENODEV (e.g: p... (...asterisk[13])

Sean Bright asteriskteam at digium.com
Tue Jul 9 07:18:33 CDT 2019


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11534 )

Change subject: openr2(2/6): Stop polling channels when DAHDI returns -ENODEV (e.g: plug-out)
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11534/2/channels/chan_dahdi.c 
File channels/chan_dahdi.c:

https://gerrit.asterisk.org/#/c/11534/2/channels/chan_dahdi.c@3708 
PS2, Line 3708: 	struct dahdi_pvt *p = openr2_chan_get_client_data(r2chan);
Having this declaration after the ast_log should be emitting a warning when compiling after ./configure --enable-dev-mode



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11534
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I10a41f617613fe7399c5bdced5c64a2751173f28
Gerrit-Change-Number: 11534
Gerrit-PatchSet: 2
Gerrit-Owner: Oron Peled <oron.peled at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 12:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190709/e761cd27/attachment.html>


More information about the asterisk-code-review mailing list