[Asterisk-code-review] openr2: bugfix in configuration saving (...asterisk[13.27])

[Oron Peled]

Hello Tzafrir Cohen,

I'd like you to do a code review. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11527

to review the following change.


Change subject: openr2: bugfix in configuration saving
......................................................................

openr2: bugfix in configuration saving

Details:
  - The memcpy() call copied part of "dahdi_conf" and not "dahdi_conf.mfcr2"
  - As a result, the memcmp() in dahdi_r2_get_link() always fails
  - This cause dahdi_r2_get_link() to create new link for every channel
    (instead of a new link for every ~30 channels)
  - With the fix, far less links are generated -- so we use far less threads

Change-Id: I7259dd6272f5e46e8a6c7f5bf3e8c2ec01b8c132
Signed-off-by: Oron Peled <oron.peled at xorcom.com>
---
M channels/chan_dahdi.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/27/11527/1

diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c
index d425b32..d00ee72 100644
--- a/channels/chan_dahdi.c
+++ b/channels/chan_dahdi.c
@@ -11984,7 +11984,7 @@
 		}
 	}
 	/* Save the configuration used to setup this link */
-	memcpy(&r2_link->conf, conf, sizeof(r2_link->conf));
+	memcpy(&r2_link->conf, &conf->mfcr2, sizeof(r2_link->conf));
 	return 0;
 }
 #endif

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11527
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13.27
Gerrit-Change-Id: I7259dd6272f5e46e8a6c7f5bf3e8c2ec01b8c132
Gerrit-Change-Number: 11527
Gerrit-PatchSet: 1
Gerrit-Owner: Oron Peled <oron.peled at xorcom.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190707/02852d30/attachment-0001.html>