[Asterisk-code-review] pjproject_bundled: Add peer information to most SSL/TLS errors (...asterisk[master])

George Joseph asteriskteam at digium.com
Mon Jul 1 09:18:07 CDT 2019


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11497 )

Change subject: pjproject_bundled:  Add peer information to most SSL/TLS errors
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/11497/2/third-party/pjproject/patches/0010-ssl_sock_ossl-sip_transport_tls-Add-peer-to-error-me.patch 
File third-party/pjproject/patches/0010-ssl_sock_ossl-sip_transport_tls-Add-peer-to-error-me.patch:

https://gerrit.asterisk.org/#/c/11497/2/third-party/pjproject/patches/0010-ssl_sock_ossl-sip_transport_tls-Add-peer-to-error-me.patch@24 
PS2, Line 24: +{ \
> Prob slightly better to use a do {.. } while () here, but this
 > should be fine. At least for current uses.

pjproject style :)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11497
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I41770e8a1ea5e96f6e16b236692c4269ce1ba91e
Gerrit-Change-Number: 11497
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 01 Jul 2019 14:18:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190701/e3339c43/attachment.html>


More information about the asterisk-code-review mailing list