[Asterisk-code-review] force inline: remove force inline type from Asterisk. (asterisk[16])

Chris Savinovich asteriskteam at digium.com
Mon Jan 28 17:53:57 CST 2019


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10931

to look at the new patch set (#2).

Change subject: force_inline: remove force_inline type from Asterisk.
......................................................................

force_inline: remove force_inline type from Asterisk.

A bug in GCC causes arithmetic calculations to fail if the
following conditions are met:
1. TEST_FRAMEWORK on
2. DONT_OPTIMIZE off
3. Fedora and Ubuntu
4. GCC 8.2.1
5. There must exist a certain combination of multithreading.
6. Optimization level -O2 and -O3
7. Flag -fpartial-inline activated (happens automatically when -O2)
Forcing inlining in our code is the actual error trigger, since it is
best to leave it to the compiler to determine what to inline (or so is
the new consensus).  Therefore this fix removes all instances of
type force_inline wherever possible throughout the Asterisk code.

Change-Id: Iad74c085d98eb61132f39d39c977ceb170d21fc9
---
M include/asterisk/sem.h
M include/asterisk/strings.h
M include/asterisk/utils.h
M main/audiohook.c
M main/sem.c
M main/strings.c
M utils/extconf.c
7 files changed, 167 insertions(+), 184 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/31/10931/2
-- 
To view, visit https://gerrit.asterisk.org/10931
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iad74c085d98eb61132f39d39c977ceb170d21fc9
Gerrit-Change-Number: 10931
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190128/cb795cfd/attachment.html>


More information about the asterisk-code-review mailing list