[Asterisk-code-review] media index.c: Refactored so it doesn't cache the index (asterisk[master])

George Joseph asteriskteam at digium.com
Mon Jan 28 12:18:03 CST 2019


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10924 )

Change subject: media_index.c: Refactored so it doesn't cache the index
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/10924/2/include/asterisk/media_index.h
File include/asterisk/media_index.h:

https://gerrit.asterisk.org/#/c/10924/2/include/asterisk/media_index.h@102
PS2, Line 102: int ast_media_index_update(struct ast_media_index *index,
> I'd still prefer we eliminate this function in master and replace
 > with a macro.

I missed that comment.  Will replace.



-- 
To view, visit https://gerrit.asterisk.org/10924
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cef327ba1b0648d85d218b70ce469ad07f4aa8d
Gerrit-Change-Number: 10924
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 18:18:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190128/c7aac7d4/attachment.html>


More information about the asterisk-code-review mailing list