[Asterisk-code-review] stasis.c: Added topic all container (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10929 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 8:

(4 comments)

Thank you for reviewing! I've fixed it!

https://gerrit.asterisk.org/#/c/10929/7/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10929/7/main/stasis.c@2228
PS7, Line 2228: 	}
> topic_proxy_cmp_fn should be used for the cmp function, just remove the topic_proxy_name_cmp functio […]
Yes, now I've got it. :) fixed it.


https://gerrit.asterisk.org/#/c/10929/7/main/stasis.c@2230
PS7, Line 2230: 	/* getting all topic in order */
> ao2_container_dup is not NULL safe, need to use: […]
Yes, fixed it.


https://gerrit.asterisk.org/#/c/10929/7/main/stasis.c@2238
PS7, Line 2238: 	ao2_cleanup(tmp_container);
> I'm sorry I wasn't quite clear in my previous comment.  You still need to unref topic. […]
Np, fixed it. :)


https://gerrit.asterisk.org/#/c/10929/7/main/stasis.c@2267
PS7, Line 2267: 		}
> You missed my comment here, can you remove which and state from this function?
Sorry!! I've missed it this part. Fixed it! :)



-- 
To view, visit https://gerrit.asterisk.org/10929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 10929
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 17:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190128/2cbe63ab/attachment-0001.html>