[Asterisk-code-review] media index.c: Refactored so it doesn't cache the index (asterisk[13])

George Joseph asteriskteam at digium.com
Mon Jan 28 10:45:48 CST 2019


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10922 )

Change subject: media_index.c: Refactored so it doesn't cache the index
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10922/1/main/loader.c
File main/loader.c:

https://gerrit.asterisk.org/#/c/10922/1/main/loader.c@a379
PS1, Line 379: 
> This should be left in place as a no-op in 13/16.  Consider the
 > following:
 > 
 > asterisk -rx 'module reload sounds http'
 > 
 > Removing the 'sounds' reload class would cause that command to
 > suddenly stop reloading 'http'.

Works for me...
*CLI> module reload sounds http
No such module 'sounds'
Module 'http' reloaded successfully.
*CLI>



-- 
To view, visit https://gerrit.asterisk.org/10922
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cef327ba1b0648d85d218b70ce469ad07f4aa8d
Gerrit-Change-Number: 10922
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 16:45:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190128/cfede8ac/attachment-0001.html>


More information about the asterisk-code-review mailing list