[Asterisk-code-review] stasis.c: Added topic all container (asterisk[master])

sungtae kim asteriskteam at digium.com
Mon Jan 28 10:23:02 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10929 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 7:

(2 comments)

Thank for reviewing, I've fixed it. :)

https://gerrit.asterisk.org/#/c/10929/6/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10929/6/main/stasis.c@476
PS6, Line 476: 		ao2_unlock(topic_all);
> A generic message is already printed via ao2_calloc. […]
Np, fixed it!


https://gerrit.asterisk.org/#/c/10929/6/main/stasis.c@2222
PS6, Line 2222: 		return CLI_SHOWUSAGE;
> This CLI command should produce output sorted by name.  The way I know to do this is: […]
Thanks. I've fixed it.



-- 
To view, visit https://gerrit.asterisk.org/10929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 10929
Gerrit-PatchSet: 7
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 16:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190128/6bf42780/attachment.html>


More information about the asterisk-code-review mailing list