[Asterisk-code-review] stasis.c: Added topic all container (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10929 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10929/2/include/asterisk/stasis.h
File include/asterisk/stasis.h:

https://gerrit.asterisk.org/#/c/10929/2/include/asterisk/stasis.h@524
PS2, Line 524: void stasis_topic_release(struct stasis_topic *topic);
If we're going to link all topics to a global container I'd strongly prefer that ao2_weakproxy objects be used to be link into the container.  This would make stasis_topic_release unneeded, code throughout asterisk would continue using ao2_cleanup to release topics.

The two examples of using ao2_weakproxy for a global container are in main/named_locks.c and main/sorcery.c.



-- 
To view, visit https://gerrit.asterisk.org/10929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 10929
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Comment-Date: Sat, 26 Jan 2019 23:25:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190126/eed52f32/attachment.html>