[Asterisk-code-review] Fix deadlock handling subscribe req during res parking reload (asterisk[13])

Giuseppe Sucameli asteriskteam at digium.com
Fri Jan 25 17:34:24 CST 2019


Giuseppe Sucameli has posted comments on this change. ( https://gerrit.asterisk.org/10701 )

Change subject: Fix deadlock handling subscribe req during res_parking reload
......................................................................


Patch Set 4:

I've re-written the patch. The new one just uses a different stasis message type, i.e. hint_remove_message_type, in order to clarify the execution flow.

IMHO even w/o my patch the flow of that part of code is not so linear. 


Furthermore by looking at the code I'm quite sure that the call to handle_hint_change_message_type(msg, AST_HINT_UPDATE_PRESENCE) added in commit 1600ebca7d9 is not executed anymore since commit d748ed4147f, but that's a different issue.


-- 
To view, visit https://gerrit.asterisk.org/10701
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b03c3455b3b12b6f83cea4cc34f4b4b20444f7e
Gerrit-Change-Number: 10701
Gerrit-PatchSet: 4
Gerrit-Owner: Giuseppe Sucameli <sucameli at netresults.it>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Giuseppe Sucameli <sucameli at netresults.it>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 23:34:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190125/ee4a510b/attachment.html>


More information about the asterisk-code-review mailing list