[Asterisk-code-review] res/res pjsip: Fix crash due to misuse of session->media bet... (asterisk[13])

[Paulo Vicentini]

Paulo Vicentini has posted comments on this change. ( https://gerrit.asterisk.org/10601 )

Change subject: res/res_pjsip: Fix crash due to misuse of session->media between threads.
......................................................................


Patch Set 7:

(4 comments)

> Patch Set 7: Code-Review+1
> 
> Paulo, does this patch apply to the 16 and master branches?

Nope,
16 and master branches implementations are totally different from 13, they rely on ast_sip_session_media_set_write_callback / ast_sip_session_media_add_read_callback and make no use of session->media on the T.38 module

https://gerrit.asterisk.org/#/c/10601/6/res/res_pjsip_t38.c
File res/res_pjsip_t38.c:

https://gerrit.asterisk.org/#/c/10601/6/res/res_pjsip_t38.c@137
PS6, Line 137: 	struct ast_datastore *datastore = NULL;
> There's no need to use a RAII_VAR here - you can ao2_ref inside the if for datastore
Done


https://gerrit.asterisk.org/#/c/10601/6/res/res_pjsip_t38.c@157
PS6, Line 157: 	}
> You can use ao2_bump here, it also makes it clear that the ref is for the datastore
Done


https://gerrit.asterisk.org/#/c/10601/6/res/res_pjsip_t38.c@490
PS6, Line 490: 		}
> There's no need to use a RAII_VAR here, an ao2_cleanup afterwards is fine.
Done


https://gerrit.asterisk.org/#/c/10601/6/res/res_pjsip_t38.c@506
PS6, Line 506: 	struct ast_sip_session *session, struct ast_frame *f)
> There's no need to use a RAII_VAR here, an ao2_cleanup afterwards is fine.
Done



-- 
To view, visit https://gerrit.asterisk.org/10601
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92e2389b8d804bf205473e92ec06217e87ce237
Gerrit-Change-Number: 10601
Gerrit-PatchSet: 7
Gerrit-Owner: Paulo Vicentini <paulo.vicentini at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Paulo Vicentini <paulo.vicentini at gmail.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 14:55:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190125/92629fb2/attachment.html>