[Asterisk-code-review] res http websocket: ensure control frames do not interfere w... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10913 )

Change subject: res_http_websocket: ensure control frames do not interfere with data
......................................................................


Patch Set 1:

> I have to admit I'm a little confused by the review process vs.
 > branches, I expected to do the cherry-picking at the very end once
 > I'd had an OK on the change.

That approach is fine.  Some of us get a little anxious when we don't see the cherry-picks though so in the future just add a comment to the review saying that you'll cherry-pick when this review is approved. :)


-- 
To view, visit https://gerrit.asterisk.org/10913
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5367144fe08ac6141bba3309517a48ec7f013bc
Gerrit-Change-Number: 10913
Gerrit-PatchSet: 1
Gerrit-Owner: Jeremy Lainé <jeremy.laine at m4x.org>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jeremy Lainé <jeremy.laine at m4x.org>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 25 Jan 2019 14:24:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190125/bb5bc0fc/attachment.html>