[Asterisk-code-review] Test cel: Fails when DONT OPTIMIZE is off (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10891 )

Change subject: Test_cel: Fails when DONT_OPTIMIZE is off
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10891/3//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10891/3//COMMIT_MSG@23
PS3, Line 23: The simple solution has
            : been to write a short loop that converts the
            : variable to lower case instead of calling function
            : ast_str_to_lower().
This is no longer true of the patch.


https://gerrit.asterisk.org/#/c/10891/3//COMMIT_MSG@27
PS3, Line 27: Note:1/22/2019. Changes applied to remove the
            : "force_inline" type from function ast_str_to_lower()
It is really silly to put a history of changes to your patch in the commit message.  The commit message is to describe your final patch version because only the final version is what gets merged into the distributed repository.  The gerrit review process is to get the patch corrected before merging it into the code base.



-- 
To view, visit https://gerrit.asterisk.org/10891
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7
Gerrit-Change-Number: 10891
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 19:00:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/4bb7bdd3/attachment.html>