[Asterisk-code-review] format g726: add support for seeking (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10907 )

Change subject: format_g726: add support for seeking
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10907/1/formats/format_g726.c
File formats/format_g726.c:

https://gerrit.asterisk.org/#/c/10907/1/formats/format_g726.c@181
PS1, Line 181: 	}
             : 	else if (whence == SEEK_CUR || whence == SEEK_FORCECUR) {
The 'else if's should go on the same line as the closing braces from the previous block


https://gerrit.asterisk.org/#/c/10907/1/formats/format_g726.c@189
PS1, Line 189: 		offset = (offset > max) ? max : offset;
             : 		offset = (offset < min) ? min : offset;
The parens aren't necessary here.


https://gerrit.asterisk.org/#/c/10907/1/formats/format_g726.c@202
PS1, Line 202: 	off_t offset;
             : 	offset = ftello(fs->f) << 1;
             : 	return offset;
Just return the calculation, there is no need for the temporary.



-- 
To view, visit https://gerrit.asterisk.org/10907
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I626235bc4642df1479050d3d06828412603a9b40
Gerrit-Change-Number: 10907
Gerrit-PatchSet: 1
Gerrit-Owner: Eyal Hasson <eyal at kolhl.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 18:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/dff58527/attachment.html>