[Asterisk-code-review] res pjsip registrar: mitigate blocked threads on reliable tr... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10906 )

Change subject: res_pjsip_registrar: mitigate blocked threads on reliable transport shutdown
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10906/1/res/res_pjsip_registrar.c
File res/res_pjsip_registrar.c:

https://gerrit.asterisk.org/#/c/10906/1/res/res_pjsip_registrar.c@394
PS1, Line 394: 	if (monitor->removing) {
> This may be a good place to document why this exists
Is register_contact_transport_shutdown_cb called while holding a lock on 'monitor?' If not you will should lock around this check.



-- 
To view, visit https://gerrit.asterisk.org/10906
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7563ca596312b1dff4f3ab41483e89fe2862328a
Gerrit-Change-Number: 10906
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 18:37:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/80f9b1fb/attachment.html>