[Asterisk-code-review] Test cel: Fails when DONT OPTIMIZE is off (asterisk[16])

Sean Bright asteriskteam at digium.com
Tue Jan 22 11:20:21 CST 2019


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10889 )

Change subject: Test_cel: Fails when DONT_OPTIMIZE is off
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10889/3//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10889/3//COMMIT_MSG@23
PS3, Line 23: of type force_inline.  The simple solution has
            : been to write a short loop that converts the
            : variable to lower case instead of calling function
            : ast_str_to_lower().
You will need to update the commit message.



-- 
To view, visit https://gerrit.asterisk.org/10889
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 17:20:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/0f0e41f1/attachment.html>


More information about the asterisk-code-review mailing list