[Asterisk-code-review] res stasis: Auto-create context and add ability to switch ap... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10882 )

Change subject: res_stasis: Auto-create context and add ability to switch applications.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c
File res/stasis/app.c:

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c@314
PS4, Line 314: 	if (app->autocontext) {
Doesn't the "registrar" argument of ast_context_destroy_by_name already handle this check for us (only deleting if the registrar matches)?  Maybe we can save a few bytes by dropping the `int autocontext` from the structure?



-- 
To view, visit https://gerrit.asterisk.org/10882
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c569468472dbb08905b356887373c81e03015d
Gerrit-Change-Number: 10882
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 15:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/7e19418a/attachment.html>