[Asterisk-code-review] Test cel: Fails when DONT OPTIMIZE is off (asterisk[13])

[Chris Savinovich]

Chris Savinovich has posted comments on this change. ( https://gerrit.asterisk.org/10891 )

Change subject: Test_cel: Fails when DONT_OPTIMIZE is off
......................................................................


Patch Set 2:

> > Not inlining ast_str_to_lower() should also fix the issue, but I
 > > didn't want to take that option cause didn't know if it was
 > > un-inlining that function was the desired goal.
 > 
 > I think the technically correct solution is to remove the forced
 > inlining. Let the compiler do its job.

That's correct Sean. I hate to say it but we had come to that conclusion this morning :)... In fact, we'll probably remove the force_inlining from all the functions at include/asterisk/strings.h.


-- 
To view, visit https://gerrit.asterisk.org/10891
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7
Gerrit-Change-Number: 10891
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 22 Jan 2019 07:07:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190122/9de0e996/attachment.html>