[Asterisk-code-review] Test cel: Fails when DONT OPTIMIZE is off (asterisk[13])

[Chris Savinovich]

Chris Savinovich has posted comments on this change. ( https://gerrit.asterisk.org/10891 )

Change subject: Test_cel: Fails when DONT_OPTIMIZE is off
......................................................................


Patch Set 2:

> What happens if you replace the tolower() in ast_str_to_lower with
 > your simple test for >= 'A' and <= 'Z'?  Does it still fail when
 > all the conditions are met?  I.E.  Is the issue inside tolower()?

Using tolower() instead of >='A' && <='Z' will also work. But I chose not  to use it to be on the safe side in case the original coder applied ast_str_to_lower() for a good reason (portability?, speed?)
The bug is not in the tolower() function itself, it is caused by the arithmetic calculations breaking up inside the inline function. It can't even add 2+2.


-- 
To view, visit https://gerrit.asterisk.org/10891
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7
Gerrit-Change-Number: 10891
Gerrit-PatchSet: 2
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 21 Jan 2019 14:37:06 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190121/aa097970/attachment.html>